fix: syntax error when running prettier on blade files (resolves #2338) #2339
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2339 +/- ##
=========================================
Coverage 97.34% 97.34%
Complexity 2188 2188
=========================================
Files 338 338
Lines 10199 10199
=========================================
Hits 9928 9928
Misses 271 271 ☔ View full report in Codecov by Sentry. |
| <x-contact-point type='email' :value="$engagement->connector->contact_email" :preferred="$engagement->connector->preferred_contact_method === 'email' && | ||
| $engagement->connector->contact_phone" /> | ||
| <x-contact-point type='email' :value="$engagement->connector->contact_email" | ||
| preferred="{{ $engagement->connector->preferred_contact_method === 'email' && $engagement->connector->contact_phone }}" /> |
There was a problem hiding this comment.
Are we sure this works? I think I remember there being a distinction where Blade components couldn't use this syntax but can't find documentation on it now.
There was a problem hiding this comment.
I have tried to test all these types of changes and I believe they are working. For example I was able to get the appended (preferred) to flip between email and phone by changing the related setting. It's worth testing out at least one of these changes again though. I think maybe org or fro contact might be easier.
Resolves #2338
NOTE: Currently eslint-config-prettier hasn't been updated to support eslint stylistic rules; which means that there is now a conflict between linting and prettier. This is seen in the datePicker.js file for the indentation of the switch/case. For now these are left to work with eslint's rules. See: prettier/eslint-config-prettier#272
Prerequisites
If this PR changes PHP code or dependencies:
composer formatand fixed any code formatting issues.composer analyzeand addressed any static analysis issues.php artisan testand ensured that all tests pass.composer localizeto update localization source files and committed any changes.If this PR changes CSS or JavaScript code or dependencies:
npm run lintand fixed any linting issues.npm run buildand ensured that CSS and JavaScript assets can be compiled.